Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu and Menubar Pattern: Clarify Tab key behavior #2266

Merged
merged 8 commits into from
May 16, 2022
Merged

Menu and Menubar Pattern: Clarify Tab key behavior #2266

merged 8 commits into from
May 16, 2022

Conversation

jongund
Copy link
Contributor

@jongund jongund commented Mar 29, 2022 •
edited by pr-preview bot
Loading

Resolves issue #2044
Updated description in menubar pattern to clarify use of tab and shift + tab.

💥 Error: 504 Gateway Timeout 💥

PR Preview failed to build. (Last tried on May 10, 2022, 3:27 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.

🔗 Related URL

<html><body><h1>504 Gateway Time-out</h1>
The server didn't respond in time.
</body></html>

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@howard-e
Copy link
Contributor

@jongund rebasing on main to get the updated index.html should solve the lint-html build error you're having here.

@jongund
Copy link
Contributor Author

jongund commented Mar 29, 2022 •
edited
Loading

@jongund rebasing on main to get the updated index.html should solve the lint-html build error you're having here.

@howard-e I just checkout this branch out from main a few hours ago and when I do a rebase this the result I get:

jongunderson@DRES-JONGUND-2018MacMini aria-practices % git branch
  main
* menubar-pattern-tab-desc
jongunderson@DRES-JONGUND-2018MacMini aria-practices % git rebase main
Current branch menubar-pattern-tab-desc is up to date.

@howard-e
Copy link
Contributor

howard-e commented Mar 29, 2022 •
edited
Loading

@howard-e I just checkout this branch out from main a few hours ago and when I do a rebase this the result I get:

@jongund seems the updated index.html went in shortly after this PR was submitted. Could you try:

git fetch origin main # or git fetch <your_local_remote_name> main
git rebase main
git push --force

My result was:

❯ gh pr checkout 2266
Branch 'menubar-pattern-tab-desc' set up to track remote branch 'menubar-pattern-tab-desc' from 'origin'.
Switched to a new branch 'menubar-pattern-tab-desc'
❯ git rebase main
Successfully rebased and updated refs/heads/menubar-pattern-tab-desc.

@jongund
Copy link
Contributor Author

jongund commented Mar 29, 2022

@howard-e
Look good now, thank you for your help.

@jongund jongund requested review from mcking65 and jnurthen April 1, 2022 13:49
@jongund jongund linked an issue Apr 1, 2022 that may be closed by this pull request
Tab key behavior Menubar pattern is not clear #2044
Closed
jnurthen
jnurthen approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@jnurthen jnurthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed Menubar PR.

The full IRC log of that discussion <Jem> Topic: Menubar PR
<Jem> https://github.com//pull/2266
<siri_> MK: Getting authentication issue when pushing to repo
<Jem> github:https://github.com//pull/2266
<siri_> MK: The content is not clear about tab moves in and out of menubar
<siri_> Matt made changes to the content and when it is pushed, ask people for review
<siri_> MK: Don't know if these are APG issues
<Jem> Matt has made some slight revision to make it clear.

jongund
jongund commented Apr 13, 2022
View reviewed changes
Copy link
Contributor Author

@jongund jongund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcking65 mcking65 requested a review from jnurthen April 13, 2022 03:08
@mcking65
Copy link
Contributor

@jongund wrote:

LGTM

Jon, you were a little too quick on the draw for me. I was diverted momentarily, and just finished up. I made a few more changes to make it especially clear that Tab does not move focus inside menus.

@mcking65 mcking65 changed the title updated tab and shift + tab for menubar pattern Menu and Menubar Pattern: Clarify Tab key behavior May 10, 2022
@mcking65 mcking65 merged commit 91dfa19 into main May 16, 2022
@mcking65 mcking65 deleted the menubar-pattern-tab-desc branch May 16, 2022 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcking65 mcking65 mcking65 approved these changes

@jnurthen jnurthen Awaiting requested review from jnurthen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Launch redesigned APG on WAI site
Development

Successfully merging this pull request may close these issues.

Tab key behavior Menubar pattern is not clear
5 participants
@jongund @howard-e @css-meeting-bot @mcking65 @jnurthen