Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added scroll to feature to the menu button example using aria-activedescendant #2057

Closed
wants to merge 10 commits into from
Closed

Added scroll to feature to the menu button example using aria-activedescendant #2057

wants to merge 10 commits into from

Conversation

jongund
Copy link
Contributor

@jongund jongund commented Oct 6, 2021

@jongund jongund requested review from jnurthen and mcking65 October 6, 2021 20:13
@jongund
Copy link
Contributor Author

jongund commented Oct 7, 2021

@mcking65 @zcorpan
Not sure who to report this problem to.

  1. Nothing I changed should have effected the regression test resullts
  2. Regression test are passing on my local machine
  3. Not sure why the END key regression test is failing on Github, but I don't think it has anything to do with my code changes.

@jongund jongund linked an issue Oct 7, 2021 that may be closed by this pull request
When using aria-activedescendant, the focused element is not scrolled into the visible area #2052
Closed
@mcking65 mcking65 mentioned this pull request Oct 10, 2021
Open
@mcking65
Copy link
Contributor

@jongund I raised #2059 for the testing issue.

@mcking65 mcking65 added Code Quality Non-functional code changes to satisfy APG code style guidelines and linters Example Page Related to a page containing an example implementation of a pattern QA for APG Examples Related to improve the quality and the acceptance of APG examples labels Oct 18, 2021
@mcking65 mcking65 added this to the 1.2 Release 1 milestone Oct 18, 2021
@jongund jongund closed this Oct 29, 2021
@zcorpan zcorpan deleted the menu-button-scroll-to branch October 29, 2021 20:03
@zcorpan zcorpan mentioned this pull request Oct 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnurthen jnurthen Awaiting requested review from jnurthen

@mcking65 mcking65 Awaiting requested review from mcking65

Assignees
No one assigned
Labels
Code Quality Non-functional code changes to satisfy APG code style guidelines and linters Example Page Related to a page containing an example implementation of a pattern QA for APG Examples Related to improve the quality and the acceptance of APG examples
Projects
Menu, Menubar, and Menu Button patterns and examples development project
Status: Complete
Milestone
1.2 Release 1
Development

Successfully merging this pull request may close these issues.

When using aria-activedescendant, the focused element is not scrolled into the visible area
2 participants
@jongund @mcking65