-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codepen title #1596
Add codepen title #1596
Conversation
Regression test coverage:Examples without any regression tests:
Examples missing some regression tests:
Example pages with Keyboard or Attribute table rows that do not have data-test-ids:
SUMMARY:55 example pages found. ERROR - missing tests: Please write missing tests for this report to pass. |
Urgh. Ok, tell me where the linebreaks need to go for:
And maybe it's not just 3 lines of code, because prettier wants more... |
If you run |
Thank-you, @nschonni ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works great, thanks @carmacleod !
The regression tests failures are flaky tests I'm fixing in another PR :) This PR can be merged. |
Thanks for considering my feedback and even taking an action for it, @carmacleod |
@nschonni since we have dependabot keeping package-lock.json up to date, should people only run npm ci in their local clones instead of npm install? Should we update our documentation? |
@mcking65 that probably is a good idea. Makes sure that people don't get new or different installs than what is run on CI or someone else's machine |
Thank you @carmacleod and @a11ydoer |
Special for @a11ydoer, this adds a title to the prefilled codepen so that it is not "untitled".
Decided to go with filename instead of directory name, because while the filename is not always ideal (e.g. many of them have "-1" or "-2a" in them, which isn't exactly semantically useful), at least the filenames are more specific, which is nice in the case of all those different comboboxes, for example. We may want to rename some of the example files. For example, "breadcrumb/index.html" has a filename of "index", which is not particularly helpful in codepen. I know that @jongund has been renaming example files recently, which is awesome.
@spectranaut and @smhigley, I'd love to get your review of this - it's only 3 lines of code. [Edit: 4 lines, because, prettier]
Let me know if you think we should go with directory name instead of filename (i.e. just "combobox", instead of "combobox-select-only"). The
34 lines of code for that would instead be: