Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date Picker Calendar Grids: Fix color contrast for selected date #1479

Merged
merged 3 commits into from
Sep 1, 2020

Conversation

carmacleod
Copy link
Contributor

@carmacleod carmacleod commented Jul 30, 2020

Closes #1478

This just implements the simplest possible fix for issue #1478
@jongund, please let me know if you like it, or if you would prefer to fix the issue some other way.

Preview Link

View example in compare branch using RawGitHack

@carmacleod carmacleod requested a review from jongund July 30, 2020 14:33
@carmacleod
Copy link
Contributor Author

carmacleod commented Jul 30, 2020

Thanks, @jongund ! I'll do the same thing for DatePicker Combobox, then.

@carmacleod
Copy link
Contributor Author

Ok, I fixed up combobox datepicker selected date color as well.

Note that for some reason, I also had to delete the following line (in addition to changing the colors for [tabindex="0"] ):

.combobox-datepicker .dates td:focus,

I don't know why I didn't have to delete the :focus line in the datepicker dialog.

Can you make sure I didn't mess something up? I've tested both, and they seem ok to me, but maybe I missed something.

@jongund
Copy link
Contributor

jongund commented Jul 30, 2020

@carmacleod

I think we still need the :focus selector, but I will test.

@jongund
Copy link
Contributor

jongund commented Jul 30, 2020

@carmacleod

Couple things I found in testing:

  • I think the background color makes the date with tabindex=0 stand out alot like it has focus. I think the background should be a little more subtle.
  • In high contrast mode on Windows we do not have a visual indicator of the current date with tabindex=0 when focus is on another control in the dialog, this is a bug in the current picker dialog, too. Is this something you could work on?

@mcking65
Copy link
Contributor

@carmacleod , based on Jon's last comment, it seems there's a little more to do here?

@mcking65 mcking65 changed the title use dark background with white text for selected date Date Picker Calendar Grids: Fix color contrast for selected date Sep 1, 2020
@mcking65 mcking65 marked this pull request as draft September 1, 2020 08:43
@mcking65 mcking65 marked this pull request as ready for review September 1, 2020 19:23
@mcking65
Copy link
Contributor

mcking65 commented Sep 1, 2020

Per discussion in today's meeting, this is ready to merge.

@mcking65 mcking65 merged commit 70c3646 into master Sep 1, 2020
@mcking65 mcking65 deleted the issue1478 branch September 1, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The calendar selected date (when it doesn't have focus) is indicated by light blue which fails 1.4.11
3 participants