Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update vnu-jar to 20.3.16 #1354

Merged
merged 2 commits into from
Mar 17, 2020
Merged

Conversation

nschonni
Copy link
Contributor

Fixes #1346
The message for img looks like it changed in the release

Fixes w3c#1346
The message for img looks like it changed in the release
Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nschonni for this update.

Interesting change; I wonder if there is a change to the test algorithm behind that change in the error message.

@mcking65 mcking65 merged commit d515746 into w3c:master Mar 17, 2020
@nschonni nschonni deleted the update-vnu-jar branch March 17, 2020 04:33
@nschonni
Copy link
Contributor Author

I think this release was supposed to add a bunch of additional aria checking, but you'd have to ask @sideshowbarker if you want the details

@sideshowbarker
Copy link
Member

I think this release was supposed to add a bunch of additional aria checking, but you'd have to ask @sideshowbarker if you want the details

Yeah, I made a bunch of fixes and additions to the ARIA-role checking behavior, to align it with the latest requirements in the current HTML-ARIA spec. Those changes have the side effect of causing some different message strings to be reported by the checker for particular case (for example, the case mentioned in this PR).

carmacleod pushed a commit to carmacleod/aria-practices that referenced this pull request Mar 31, 2020
Fixes w3c#1346: The message for img changed.

* chore: Update vnu-jar to 20.3.16
* fix: update acorn for npm audit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An in-range update of vnu-jar is breaking the build 🚨
3 participants