Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidelines for range related properties #1279

Merged
merged 63 commits into from
Jul 7, 2020
Merged
Changes from 1 commit
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
3a2d977
Draft range related properties
Mar 14, 2019
7955203
Minor fixes
Mar 14, 2019
b382e78
Address feedback
zcorpan Apr 23, 2019
9eefa62
Review feedback
Jun 20, 2019
8065be0
Move section into aria-practices.html
zcorpan Aug 30, 2019
2f8d7a1
Fix a broken link
zcorpan Dec 3, 2019
2b5fa5a
Fix markup
zcorpan Dec 3, 2019
ff195f2
Rename some headings, add a table for valuemin/max
zcorpan Dec 3, 2019
e7ccbb8
Expand on aria-valuenow
zcorpan Dec 3, 2019
33fa65e
Formatting of markup
zcorpan Dec 3, 2019
f28246b
Fix a factual error about which properties are required for spinbutton
zcorpan Dec 3, 2019
4ebf1d7
Clarify table for aria-valuemin/max
zcorpan Dec 4, 2019
8af8dc1
Reorder roles alphabetically
zcorpan Dec 4, 2019
de54321
The only range without min/max is spinbutton
zcorpan Dec 4, 2019
171151a
Add an example for aria-valuetext
zcorpan Dec 4, 2019
4dffa19
Tweaks wording for undefined range; indeterminate progress bars can s…
zcorpan Dec 4, 2019
541b9d4
Editorial revisions to introduction
mcking65 Dec 10, 2019
1f02c30
Further editorial simplification of introduction
mcking65 Dec 10, 2019
bfbfe30
Further editorial revision to intro
mcking65 Dec 10, 2019
c0a18e9
Refine definition table in intro
mcking65 Dec 10, 2019
f4c9cc1
Delete unnecessary 'is'
mcking65 Dec 10, 2019
9d5b744
Editorial revisions to min and max section
mcking65 Dec 10, 2019
55b86f6
Editorial revisions to valuenow section
mcking65 Dec 10, 2019
7882709
Section title: of -> for
mcking65 Dec 10, 2019
3c27fea
Apply suggestions from code review
zcorpan Jan 9, 2020
f7631e9
added meter example under range properties
a11ydoer Feb 22, 2020
a97ebf3
Editorial: meter shows current (not changed) CPU usage
carmacleod Feb 26, 2020
8890612
Editorial: aria-valuenow is required, so no default value
carmacleod Feb 26, 2020
00f796b
Add label to example code
carmacleod Feb 26, 2020
1e7c627
Update section 8.1
carmacleod Mar 3, 2020
ad2e512
update range aria value properties in summary table and each role acc…
a11ydoer Apr 5, 2020
af32cfc
update meter ranage and add and modify suggested ph exmaple
a11ydoer Apr 6, 2020
ae55151
editorial and exmaple code change with comments
a11ydoer May 11, 2020
2ed177f
fixed some of testing failure
a11ydoer May 11, 2020
d26175b
Change H2 to H3 for subsections that had wrong heading level
mcking65 May 12, 2020
f617409
valuetext: minor editorial revisions for style
mcking65 May 12, 2020
a5551cb
valuetext subsection: Remove value min and max from meter example
mcking65 May 12, 2020
03fc089
meter role: editorial revisions for style
mcking65 May 12, 2020
8de7bc1
Add link to meter design pattern
mcking65 May 12, 2020
454c86c
add missing end tag for code
carmacleod May 26, 2020
60b1dc3
remove "not exactly" so that progressbar aria-valuenow is required if…
carmacleod May 26, 2020
8c39d7f
use more common language
carmacleod May 27, 2020
fd01798
fix plural/singular
carmacleod May 27, 2020
6c66a07
fewer words
carmacleod May 27, 2020
8223e98
add missing "the"
carmacleod May 27, 2020
dbf9361
fix tense
carmacleod May 27, 2020
6ba425c
editorial: full explain -> fully explain
carmacleod May 27, 2020
82ff06e
reword so that using aria-valuetext is sentence subject, not AT
carmacleod May 27, 2020
7857586
fix plural/singular in sentence and role name
carmacleod May 27, 2020
acc9d88
add missing code tags
carmacleod May 27, 2020
f94fa26
reorder sentence for clarity
carmacleod May 27, 2020
2b9cdf4
use slightly more interesting word
carmacleod May 27, 2020
62ffa4d
fix plural/singular
carmacleod May 27, 2020
045f597
change range property table and code comment type
a11ydoer Jun 2, 2020
864db2b
remove duplicate html spin button example and switch the order of ind…
a11ydoer Jun 2, 2020
75daeb2
textual > text
mcking65 Jul 1, 2020
6253cd7
Revise intro to second meter example for ease of understanding
mcking65 Jul 1, 2020
fe3a311
Editorial simplification of progress bar
mcking65 Jul 1, 2020
6c9081c
Minor editorial revisions to spinbutton section for clarity
mcking65 Jul 1, 2020
07541b7
Apply suggestions by @carmacleod from review
mcking65 Jul 7, 2020
1985db4
Clarify usage of min, max, and now per feedback from @jongund
mcking65 Jul 7, 2020
d893526
change capitalized The to lowercase the
carmacleod Jul 7, 2020
311e7be
Merge branch 'master' into zcorpan/range-related-properties-2
mcking65 Jul 7, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Editorial simplification of progress bar
  • Loading branch information
mcking65 committed Jul 1, 2020
commit fe3a311971d810e9609bfcbbbb92e5e6174c82c4
20 changes: 6 additions & 14 deletions aria-practices.html
Original file line number Diff line number Diff line change
Expand Up @@ -6615,14 +6615,10 @@ <h3>Range properties with progress bars</h3>

<p>
The <code>aria-valuemin</code> and <code>aria-valuemax</code> properties only need to be set for the <code>progressbar</code> role when the progress bar's minimum is not 0 or the maximum value is not 100.
The aria-valuenow property is required for <code>progressbar</code> if the value is known (e.g. not indeterminate). If the <code>aria-valuenow</code> property is set, the author needs to make sure it is within the minimum and maximum values.
</p>
<p>The Range properties are necessary for communicating the state of a progress bar to assistive technologies.
</p>
<p>
This is an example of a progress bar represented by an SVG.
The range properties are necessary to fully explain the widget to assistive technologies.
The aria-valuenow property needs to be set for a <code>progressbar</code> if its value is known (e.g. not indeterminate).
If the <code>aria-valuenow</code> property is set, the author needs to make sure it is within the minimum and maximum values.
</p>
<p>Following is an example of a progress bar represented by an SVG.</p>

<pre><code>&lt;div&gt;Loading:
&lt;!-- The progress bar uses the default values of 0 and 100 for aria-valuemin and aria-valuemax --&gt;
Expand All @@ -6634,17 +6630,13 @@ <h3>Range properties with progress bars</h3>
&lt;/svg&gt;
&lt;/span&gt;
&lt;/div&gt;</code></pre>
<p>
The progress bar example can also be made using the native HTML <code>progress</code> element.
</p>
<p>This progress bar can also be made using the native HTML <code>progress</code> element.</p>

<pre><code>&lt;label for="loadstatus"&gt;Loading:&lt;/label&gt;
&lt;progress id="loadstatus" max="100" value="33"&gt;&lt;/progress&gt;
</code></pre>
<p>
To represent an indeterminate progress bar where the value range is unknown,
omit the <code>aria-valuenow</code> attribute.
</p>

<p>To represent an indeterminate progress bar where the value range is unknown, omit the <code>aria-valuenow</code> attribute.</p>

<pre><code>&lt;img role="progressbar" src="spinner.gif" alt="Loading..."&gt;</code></pre>
</section>
Expand Down