-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add site navigation example that uses disclosure buttons that show lists of links #1028
Comments
See excellent discussion of design decisions in the conversation thread of pull request #1036. |
@@smhigley, I am done with editorial revisions to the issue1028-disclosure-menu-example feature branch. You may want to review the test code. I added documentation for aria-current, which currently does not have a test. I also expanded the documentation for arrow keys, home, and end. Now, there are multiple rows with the same data-test-id, which is OK. However, it might be good to sanity check to make sure the testing covers all the documented behaviors. My revisions to the accessibility features section were the most significant. They are worth a close read. I attempted to adjust wording and rationale to be understandable by a broader audience. I'm curious if you agree whether I achieved that objective. |
I am wondering if the checkbox for optional navigation keys should be unchecked by default. Given there are both side effects and extra code driven by the optional behaviors, shouldn't they be off by default? |
To resolve issue #1028, adds a disclosure pattern example that illustrates a simple site navigation bar with dropdowns. The navigation bar is a set of disclosure buttons that show and hide dropdown lists of links.
Thank you thank you @smhigley ! |
Develop an example of a site navigation system that uses disclosure buttons that show and hide simple lists of links that is similar to the site navigation provided on www.usa.gov.
Preview Link for WIP
View disclosure navigation menu example in the issue1028-disclosure-menu-example branch
The text was updated successfully, but these errors were encountered: