Skip to content

Commit

Permalink
Regression Tests: Add and update data-test-ids (pull #864)
Browse files Browse the repository at this point in the history
* Add data-test-ids to table/table.html
* Remove untestable attribute data-test-ids from alert.html
  • Loading branch information
spectranaut authored and mcking65 committed Aug 29, 2018
1 parent 4992388 commit 1379511
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions examples/alert/alert.html
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ <h2 id="rps_label">Role, Property, State, and Tabindex Attributes</h2>
<td><code>div</code></td>
<td>Identifies the element as the container where alert content will be added or updated.</td>
</tr>
<tr data-test-id="alert-aria-live">
<tr>
<td></td>
<th scope="row"><code>aria-live=<q>assertive</q></code></th>
<td>Implicit on <code>div</code></td>
Expand All @@ -96,7 +96,7 @@ <h2 id="rps_label">Role, Property, State, and Tabindex Attributes</h2>
</ul>
</td>
</tr>
<tr data-test-id="alert-aria-atomic">
<tr>
<td></td>
<th scope="row"><code>aria-atomic=<q>true</q></code></th>
<td>Implicit on <code>div</code></td>
Expand Down
14 changes: 7 additions & 7 deletions examples/table/table.html
Original file line number Diff line number Diff line change
Expand Up @@ -103,29 +103,29 @@ <h2 id="rps_label">Role, Property, State, and Tabindex Attributes</h2>
</tr>
</thead>
<tbody>
<tr>
<tr data-test-id="table-role">
<th scope="row"><code>table</code></th>
<td></td>
<td><code>div</code></td>
<td>Identifies the element containing the table structure.</td>
</tr>
<tr>
<tr data-test-id="table-aria-label">
<td></td>
<th scope="row">
<code>aria-label=&quot;Students&quot;</code>
</th>
<td><code>div</code></td>
<td>Provides an accessible name for the table.</td>
</tr>
<tr>
<tr data-test-id="table-aria-describedby">
<td></td>
<th scope="row">
<code>aria-describedby=&quot;IDREF&quot;</code>
</th>
<td><code>div</code></td>
<td>Refers to the element that serves as the caption for the table.</td>
</tr>
<tr>
<tr data-test-id="rowgroup-role">
<th scope="row"><code>rowgroup</code></th>
<td></td>
<td><code>div</code></td>
Expand All @@ -136,19 +136,19 @@ <h2 id="rps_label">Role, Property, State, and Tabindex Attributes</h2>
</ul>
</td>
</tr>
<tr>
<tr data-test-id="row-role">
<th scope="row"><code>row</code></th>
<td></td>
<td><code>div</code></td>
<td>Identifies each element that contains the cells for a row.</td>
</tr>
<tr>
<tr data-test-id="columnheader-role">
<th scope="row"><code>columnheader</code></th>
<td></td>
<td><code>span</code></td>
<td>Identifies elements that serve as a cell containing a column label.</td>
</tr>
<tr>
<tr data-test-id="cell-role">
<th scope="row"><code>cell</code></th>
<td></td>
<td><code>span</code></td>
Expand Down

0 comments on commit 1379511

Please sign in to comment.