Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation MVP #879

Merged
merged 168 commits into from
Jan 22, 2024
Merged

Automation MVP #879

merged 168 commits into from
Jan 22, 2024

Conversation

stalgiag
Copy link
Contributor

@stalgiag stalgiag commented Dec 14, 2023

This PR is a combination of the Automation MVP feature currently in sandbox and the most recent changes on main. I've tested locally and could not find any issues. That said, there are substantials changes with this feature and there has been significant active development on main since this feature began to be developed separately. I would be grateful for any additional manual testing.

There are have been several steps of code review on the new feature code but more is welcome in instances where this would be helpful and not an unnecessary burden on the reviewer. Especially with regards to how merge conflicts were handled with main.

To manually test:

  1. go to "Test Queue"
  2. Click "Add a Test Plan to the Test Queue" and add an NVDA/Chrome test plan
  3. Click "Add and run with bot"
  4. Experiment with managing the bot, adding it through other means, reviewing its output, etc

howard-e and others added 30 commits August 21, 2023 16:32
… before the associated reports were all marked as final (but the tests were 100% done in the Test Queue)
* Refine raise an issue behavior

* Address feedback

* Fixed squished dot icon

* Address last feedback

* Hide closed issues on datamgmt page
…lt, avoid passing context for persistConflictCount, more work on AutomationController
@stalgiag
Copy link
Contributor Author

I am super impressed by the approach and subsequent implementation of the automation bot.

In my review of the code, I could not find anything glaring to comment on here. However, when testing functionality I did find some things to bring to your attention:

The first thing is that the bot did not complete it's testing on 3 out of the 5 test plans for which it is able to run tests. It completed all tests for the Toggle Button V22.05.18 test plan and the Checkbox Example (Mixed-State) V23.08.23 test plan. But it did not compete the tests for Select Only Combobox Example V22.03.17: SCR-20231220-jkea Alert Example V23.12.06: SCR-20231220-jkrk Modal Dialog Example V22.05.26: SCR-20231220-jlce

The UI listing with the colored bullets disappears if I click the "Manage NVDA Bot" button then press "Stop Running". I think that that UI should remain for bot run tests.

That's it! Exceptional work!

Thanks for checking it out @Paul-Clue and thanks for the screenshots!

I am able to run all of those tests without issue in both local and prod environments. Is it possible that something could've happened to your app server while those tests were running? For example, a save while a simulated job is running could wipe out the timeouts running the simulated workflow. If you are pretty sure that your server isn't restarting and nothing is unexpected in your system, can you let me know if there is any info in any of the consoles (terminal running the app server and browser.console)?

@Paul-Clue
Copy link
Collaborator

Hey, @stalgiag, I rebuilt the database and pulled all the new changes. The bot is working fine now (completing all the tests for the tests plans that are run) and much faster too!

* Prevent multiple bot runs in AddTestToQueueWithConfirmation

* Render checkmark for assigned bot

* Update AddTestToQueueWithConfirmation test

* More readable conditional sequence in AssignTeserDropdown

* useMemo for alreadyHasBotInTestPlanReport in AddTestToQueueWithConfirmation
@stalgiag stalgiag requested review from alflennik and Paul-Clue and removed request for howard-e December 21, 2023 22:46
@alflennik
Copy link
Contributor

Shall we mark this ready for review @stalgiag? Seems to be pretty close.

stalgiag and others added 2 commits January 9, 2024 16:06
* Add NVDA Bot user using seeder

* Populate NVDA Bot user from single source, remove code for creating user in service

* Use centralized username for bot user

Co-authored-by: jugglinmike <[email protected]>

---------

Co-authored-by: jugglinmike <[email protected]>
…2 tests (#886)

* Support rowNumber identification using presentationNumber for v2 tests

* Update error message

---------

Co-authored-by: Mike Pennisi <[email protected]>
@stalgiag stalgiag marked this pull request as ready for review January 10, 2024 16:57
@stalgiag stalgiag merged commit eae0957 into main Jan 22, 2024
2 checks passed
@stalgiag stalgiag deleted the automation-mvp-merged branch January 22, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants