-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automation MVP #879
Automation MVP #879
Conversation
… before the associated reports were all marked as final (but the tests were 100% done in the Test Queue)
* Refine raise an issue behavior * Address feedback * Fixed squished dot icon * Address last feedback * Hide closed issues on datamgmt page
…lt, avoid passing context for persistConflictCount, more work on AutomationController
Thanks for checking it out @Paul-Clue and thanks for the screenshots! I am able to run all of those tests without issue in both local and prod environments. Is it possible that something could've happened to your app server while those tests were running? For example, a save while a simulated job is running could wipe out the timeouts running the simulated workflow. If you are pretty sure that your server isn't restarting and nothing is unexpected in your system, can you let me know if there is any info in any of the consoles (terminal running the app server and browser.console)? |
Hey, @stalgiag, I rebuilt the database and pulled all the new changes. The bot is working fine now (completing all the tests for the tests plans that are run) and much faster too! |
* Prevent multiple bot runs in AddTestToQueueWithConfirmation * Render checkmark for assigned bot * Update AddTestToQueueWithConfirmation test * More readable conditional sequence in AssignTeserDropdown * useMemo for alreadyHasBotInTestPlanReport in AddTestToQueueWithConfirmation
Shall we mark this ready for review @stalgiag? Seems to be pretty close. |
* Add NVDA Bot user using seeder * Populate NVDA Bot user from single source, remove code for creating user in service * Use centralized username for bot user Co-authored-by: jugglinmike <[email protected]> --------- Co-authored-by: jugglinmike <[email protected]>
…2 tests (#886) * Support rowNumber identification using presentationNumber for v2 tests * Update error message --------- Co-authored-by: Mike Pennisi <[email protected]>
This PR is a combination of the Automation MVP feature currently in sandbox and the most recent changes on main. I've tested locally and could not find any issues. That said, there are substantials changes with this feature and there has been significant active development on main since this feature began to be developed separately. I would be grateful for any additional manual testing.
There are have been several steps of code review on the new feature code but more is welcome in instances where this would be helpful and not an unnecessary burden on the reviewer. Especially with regards to how merge conflicts were handled with main.
To manually test: