Adds -f bytecode_runtime support. #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacqueswww
force-pushed
the
bytecode_runtime_output
branch
from
913a87d to
4c2f0bf
Compare
|
Nice! Coverage decreased from the added statements... Do we have open loop cases just showing that some bytecode is produced for all of these outputs? It doesn't necessarily need to match anything, just produce something other than empty. That will gain coverage for these circumstances |
|
Ah yes good idea, I was contemplating how to write a test for this change 😋 |
|
@DavidKnott @fubuloubu I added the necessary the -0.0001% (or whichever it is) are the extra changes in the viper bin. Which we just have to live with for now :) |
|
Love it |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Adds -f bytecode_runtime support. For populus integration the runtime bytecode is required, this adds a format to the viper binary. The solc equivalent would be:
--bin-runtime.- How I did it
Came up for the populus integration. Traced the lll output from -f ir.
- How to verify it
Hmm not sure, place a debugger in
def compileand check the lll value.- Description for the changelog
Adds support for -f bytecode_runtime.
- Cute Animal Picture