Create vip template #467
Merged
Create vip template #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacqueswww
approved these changes
Nov 14, 2017
chgue
suggested changes
Nov 14, 2017
.github/VIP_TEMPLATE.md
Outdated
| "If you can't explain it simply, you don't understand it well enough." Provide a simplified and layman-accessible explanation of the VIP. | ||
|
|
||
| ## Abstract | ||
| A short (description of the technical issue being addressed. |
.github/VIP_TEMPLATE.md
Outdated
| A short (description of the technical issue being addressed. | ||
|
|
||
| ## Motivation | ||
| The motivation is critical for VIPs that add or change Viper's functionality. It should clearly explain why the existing Viper functionality is inadequate to address the problem that the VIP solves. as well as how the VIP is in line with Viper's goals and design philosopy. |
There was a problem hiding this comment.
Small typo: "solves. as well"
DavidKnott
force-pushed
the
create-vip-template
branch
from
d0521d8 to
bb3f546
Compare
|
@chgue Made the changes you requested and added a link to it in |
chgue
reviewed
Nov 14, 2017
docs/contributing.rst
Outdated
| @@ -17,10 +17,18 @@ In particular, we need help in the following areas: | |||
| * Responding to questions from other users on `StackExchange | |||
| <https://ethereum.stackexchange.com>`_ and the `Viper Gitter | |||
| <https://gitter.im/ethereum/viper>`_ | |||
| * Suggesting Improvements | |||
| <https://github.com/ethereum/viper/tree/master/.github/VIP_TEMPLATE.md`_ | |||
There was a problem hiding this comment.
@DavidKnott Thanks for adding it to the docs! There is a closing ">" missing before the "`" here and in the change below.
DavidKnott
force-pushed
the
create-vip-template
branch
from
bb3f546 to
b4625db
Compare
DavidKnott
force-pushed
the
create-vip-template
branch
from
b4625db to
132d337
Compare
|
@chgue Great catch, I added the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Create VIP (Viper Improvement Proposal) template to facilitate discussion around the addition features to Viper.
- How I did it
I looked at the Ethereum EIP (Ethereum Improvement Proposal) template and took what I felt would be relevant for Viper
- How to verify it
Read the template
- Description for the changelog
None
- Cute Animal Picture