Remove tester ref from assert_tx_failed() #446
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
I noticed that
assert_tx_failed()
fixture required a reference totester
that could just be referenced internally, fixing some usage issues people have been having. I wanted to also get rid of needinglambda:
but couldn't at this point- How I did it
Greped for all uses in
tests/
and updatedsetup_transaction_tests.py
- How to verify it
Check out what tests I changed
Run pytest
- Description for the changelog
Modified assert_tx_failed() to remove reference to tester as tester reference was already provided internally
- Cute Animal Picture