Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tester ref from assert_tx_failed() #446

Merged
merged 1 commit into from
Nov 12, 2017

Conversation

fubuloubu
Copy link
Member

- What I did

I noticed that assert_tx_failed() fixture required a reference to tester that could just be referenced internally, fixing some usage issues people have been having. I wanted to also get rid of needing lambda: but couldn't at this point

- How I did it

Greped for all uses in tests/ and updated setup_transaction_tests.py

- How to verify it

Check out what tests I changed
Run pytest

- Description for the changelog

Modified assert_tx_failed() to remove reference to tester as tester reference was already provided internally

- Cute Animal Picture

puma

…eference inside setup_transaction_tests.py was referencing the same module
@jacqueswww
Copy link
Contributor

I like it! One less parameter makes it even easier to use :)

@fubuloubu
Copy link
Member Author

fubuloubu commented Nov 7, 2017

Yeah. The next step is that it should be a pytest fixture inside conftest.py, then simplifying what's going on inside setup_transaction_tests.py and making it so we don't have to import all these helpers which are basically fixtures

@DavidKnott
Copy link
Contributor

LGTM

@DavidKnott DavidKnott merged commit d8f61c7 into vyperlang:master Nov 12, 2017
@fubuloubu fubuloubu deleted the remove_tester_ref branch December 26, 2017 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants