Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the problems when install viper in Ubuntu16.04 #442

Merged
merged 1 commit into from
Nov 5, 2017
Merged

fix the problems when install viper in Ubuntu16.04 #442

merged 1 commit into from
Nov 5, 2017

Conversation

kaikai1024
Copy link

- What I did

little doc fix

- How I did it

find it when i install viper

- How to verify it

i don't know if it is ok while os is not Ubuntu16.04

- Description for the changelog

fix it when install python3.6 and use virtualenv

- Cute Animal Picture

: -D

put a cute animal picture here.

Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @DavidKnott

@@ -75,7 +75,7 @@ other development environment set-up.

To create a new virtual environment for Viper run the following commands:
::
virtualenv -p /usr/local/lib/python3.6/bin/python --no-site-packages ~/viper-venv
virtualenv -p /usr/local/lib/python3.6/bin/python3 --no-site-packages ~/viper-venv
Copy link
Member

@fubuloubu fubuloubu Nov 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is my bad, I created a symlink python pointing to python3 I think got copied when I showed the original author my install instructions for 16.04.

Copy link
Author

@kaikai1024 kaikai1024 Nov 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And i wonder if it's better to add some examples just like the doc of the solidity

exampleOfTheSolidity

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have examples in a separate section we are working on integrating into the docs

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@DavidKnott
Copy link
Contributor

LGTM

@DavidKnott DavidKnott merged commit f9b3b75 into vyperlang:master Nov 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants