Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest release of TypeScript 2.1.5 #72

Merged
merged 1 commit into from
Feb 10, 2017
Merged

Conversation

xiamx
Copy link
Contributor

@xiamx xiamx commented Jan 24, 2017

Hi,

TypeScript 2.1 has been released for sometime. It's time to remove the require of -dev peerDependencies

package.json Outdated
@@ -36,7 +36,7 @@
"glob-expand": "^0.2.1"
},
"peerDependencies": {
"typescript": "^2.0.6 || >=2.1.0-dev || >=2.2.0-dev"
"typescript": "^2.0.6 || ^2.1.5 || >=2.2.0-dev"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^2.0.6 contains 2.1.5. this change is not required. 😉

https://runkit.com/npm/semver

var semver = require('semver');

console.log(semver.satisfies('2.0.10', '^2.0.6 || >=2.1.0-dev || >=2.2.0-dev'));
console.log(semver.satisfies('2.1.5', '^2.0.6 || >=2.1.0-dev || >=2.2.0-dev'));
console.log(semver.satisfies('2.1.0-dev.20161110', '^2.0.6 || >=2.1.0-dev || >=2.2.0-dev'));
console.log(semver.satisfies('2.2.0-dev.20170124', '^2.0.6 || >=2.1.0-dev || >=2.2.0-dev'));

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, I was also wondering about this part too. But there might be a problem in how npm evaluates semver in peer dependency

npm WARN [email protected] requires a peer of typescript@^2.0.6 || >=2.1.0-dev || >=2.2.0-dev but none was installed.
➜  ~ tsc -v
Version 2.1.4

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it try with -g options?
Unfortunately it is expected behavior.
try with npm install -g typescript typescript-formatter in same time. npm don't report that error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup that worked.

@vvakame
Copy link
Owner

vvakame commented Jan 25, 2017

thank you for your contributions.
We need update devDependencies only.

@xiamx
Copy link
Contributor Author

xiamx commented Feb 8, 2017

all done :)

@vvakame vvakame merged commit 248e114 into vvakame:master Feb 10, 2017
@vvakame
Copy link
Owner

vvakame commented Feb 10, 2017

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants