Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read list of files to format from tsconfig.json #22

Merged
merged 2 commits into from
Sep 22, 2015

Conversation

robertknight
Copy link
Contributor

If no files to process are specified on the command-line
but a tsconfig.json file exists, then read the list of files
to format from that.

This provides an easy way to reformat all source files
in a TypeScript project using tsfmt -r.

I apologize for the formatting changes in cli.ts - I ran ./bin/tsfmt -r lib/cli.ts (of course) and it ended up reformatting existing code as well as my actual changes. I expected to find a source formatting task in the Gruntfile. Did I miss something?

If no files to process are specified on the command-line
but a tsconfig.json file exists, then read the list of files
to format from that.

This provides an easy way to reformat all source files
in a TypeScript project using `tsfmt -r`.
@robertknight robertknight force-pushed the read-files-from-tsconfig branch from 8faac63 to de8e10c Compare August 30, 2015 21:00
@robertknight
Copy link
Contributor Author

I apologize for the formatting changes in cli.ts - I ran ./bin/tsfmt -r lib/cli.ts (of course) and
it ended up reformatting existing code as well as my actual changes.

I've fixed this. I had an old version of TypeScript installed in my checkout of typescript-formatter. Updating it and re-running tsfmt solved the problem.

@vvakame vvakame self-assigned this Aug 31, 2015
@vvakame
Copy link
Owner

vvakame commented Aug 31, 2015

sounds great! I'll take a look later. 👍

Add test to verify that CLI reads files from tsconfig.json
@vvakame vvakame merged commit eaf3cbd into vvakame:master Sep 22, 2015
@vvakame
Copy link
Owner

vvakame commented Sep 22, 2015

it merged, thanks! 👍
sorry for delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants