Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#534 add support for tags with nodepools #549

Merged
merged 1 commit into from
Nov 16, 2021
Merged

#534 add support for tags with nodepools #549

merged 1 commit into from
Nov 16, 2021

Conversation

spencerkordecki
Copy link
Collaborator

Description

Adds support for tag parameter and updates test cases to return the tags in node pool operations. Additionally, does some renaming in mock responses to match the documentation.

Related Issues

Resolves #534

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@ddymko ddymko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ddymko ddymko merged commit 5aca99d into master Nov 16, 2021
@spencerkordecki spencerkordecki deleted the issue-534 branch November 28, 2021 15:05
@spencerkordecki spencerkordecki added this to the v2.3.0 milestone Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubernetes - Nodepool tag support
2 participants