Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add os parameter by plans.listPlans and fix url by startupScripts #460

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

apeters1827
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #460 (e12b933) into master (502e561) will not change coverage.
The diff coverage is n/a.

❗ Current head e12b933 differs from pull request most recent head 25931a8. Consider uploading reports for the commit 25931a8 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #460   +/-   ##
=======================================
  Coverage   99.29%   99.29%           
=======================================
  Files          24       24           
  Lines         283      283           
  Branches       26       26           
=======================================
  Hits          281      281           
  Misses          2        2           
Impacted Files Coverage Δ
src/api/plans.js 100.00% <ø> (ø)
src/api/startup-scripts.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 502e561...25931a8. Read the comment docs.

@ddymko ddymko requested a review from spencerkordecki March 24, 2021 20:43
@ddymko
Copy link
Contributor

ddymko commented Mar 24, 2021

@spencerkordecki the OS field for plans was recently added as a new query param to get plans specific for windows

https://www.vultr.com/api/#operation/list-plans

@ddymko
Copy link
Contributor

ddymko commented Mar 24, 2021

@gabos31 Thanks for going through and patching bugs you come across

@spencerkordecki spencerkordecki merged commit 2a19377 into vultr:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants