Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 444 #445

Merged
merged 2 commits into from
Mar 18, 2021
Merged

Issue 444 #445

merged 2 commits into from
Mar 18, 2021

Conversation

spencerkordecki
Copy link
Collaborator

Description

Fixes #444 by changing the request type from POST to GET as is specified in the documentation

Related Issues

#444

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@spencerkordecki spencerkordecki requested review from ddymko and afady March 18, 2021 12:18
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #445 (39ab411) into master (8f17c00) will not change coverage.
The diff coverage is n/a.

❗ Current head 39ab411 differs from pull request most recent head cb68535. Consider uploading reports for the commit cb68535 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #445   +/-   ##
=======================================
  Coverage   99.29%   99.29%           
=======================================
  Files          24       24           
  Lines         283      283           
  Branches       26       26           
=======================================
  Hits          281      281           
  Misses          2        2           
Impacted Files Coverage Δ
src/api/instances.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f17c00...cb68535. Read the comment docs.

@ddymko ddymko merged commit 091b255 into master Mar 18, 2021
@ddymko ddymko deleted the issue-444 branch March 18, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

instances.listInstanceIpv4Information() bug
2 participants