Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes #434 #435

Closed
wants to merge 1 commit into from
Closed

Bug fixes #434 #435

wants to merge 1 commit into from

Conversation

devhun
Copy link
Contributor

@devhun devhun commented Feb 24, 2021

Related Issues

Fixes #434

@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #435 (db984f7) into master (5d9874e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #435   +/-   ##
=======================================
  Coverage   99.29%   99.29%           
=======================================
  Files          24       24           
  Lines         283      283           
  Branches       26       26           
=======================================
  Hits          281      281           
  Misses          2        2           
Impacted Files Coverage Δ
src/api/dns.js 100.00% <ø> (ø)
src/util.js 94.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d9874e...9bc7dc4. Read the comment docs.

@ddymko
Copy link
Contributor

ddymko commented Feb 24, 2021

@devhun The package.json, package-lock.json and changelog.md will have to be opened in another ticket by us to cut a new release.

This PR should only have fixes for the bug at hand

@devhun devhun closed this Feb 24, 2021
@devhun devhun deleted the vultr/issue-434 branch February 24, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Version 2.0.0 can't create a dns record
2 participants