Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace request with node-fetch, fix getHealthCheckInfo false positive tests #347

Merged
merged 3 commits into from
Jun 12, 2020

Conversation

spencerkordecki
Copy link
Collaborator

Description

  • Replaces request with node-fetch due to request being deprecated (see: Request’s Past, Present and Future request/request#3142)
  • Fixes getHealthCheckInfo tests by fixing casing of the mock data to fix the silently failing tests
  • Removes comma dangle as default setting in prettier due to upgrade to Prettier 2.X

Related Issues

Implements #332

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@spencerkordecki spencerkordecki requested a review from ddymko June 12, 2020 14:15
@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #347 into master will decrease coverage by 4.60%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
- Coverage   82.80%   78.20%   -4.61%     
==========================================
  Files          23       23              
  Lines         221      234      +13     
  Branches       19       21       +2     
==========================================
  Hits          183      183              
- Misses         38       51      +13     
Impacted Files Coverage Δ
src/api/load-balancer.js 100.00% <ø> (ø)
src/util.js 4.16% <0.00%> (-4.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc9610c...a3d2be2. Read the comment docs.

@ddymko
Copy link
Contributor

ddymko commented Jun 12, 2020

Closes #332

@ddymko ddymko linked an issue Jun 12, 2020 that may be closed by this pull request
@ddymko ddymko merged commit 0259258 into master Jun 12, 2020
@ddymko ddymko added this to the v0.3.2 milestone Jul 15, 2020
@ddymko ddymko mentioned this pull request Jul 15, 2020
3 tasks
@spencerkordecki spencerkordecki deleted the replace-request-library branch October 30, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace "request" library due to deprecation
2 participants