Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Balancers #336

Merged
merged 3 commits into from
May 1, 2020
Merged

Load Balancers #336

merged 3 commits into from
May 1, 2020

Conversation

spencerkordecki
Copy link
Collaborator

Description

Implements the necessary calls to interact with the new load balancer API, regenerated documentation to include all these calls with their documentation

Related Issues

#333

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@spencerkordecki spencerkordecki requested review from ddymko and afady April 25, 2020 23:47
@codecov
Copy link

codecov bot commented Apr 25, 2020

Codecov Report

Merging #336 into master will increase coverage by 1.61%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
+ Coverage   81.18%   82.80%   +1.61%     
==========================================
  Files          22       23       +1     
  Lines         202      221      +19     
  Branches       19       19              
==========================================
+ Hits          164      183      +19     
  Misses         38       38              
Impacted Files Coverage Δ
src/api/load-balancer.js 100.00% <100.00%> (ø)
src/index.js 49.09% <100.00%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b0db56...f531ff1. Read the comment docs.

afady
afady previously approved these changes Apr 27, 2020
@ddymko ddymko added this to the v0.3.0 milestone May 1, 2020
@ddymko
Copy link
Contributor

ddymko commented May 1, 2020

Closes #333

@ddymko ddymko merged commit f30cba5 into master May 1, 2020
@ddymko ddymko added the enhancement New feature or request label May 1, 2020
@ddymko ddymko mentioned this pull request May 1, 2020
3 tasks
@spencerkordecki spencerkordecki deleted the load-balancers branch October 30, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants