Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VListItem): properly display active-color when active #13912

Merged
merged 2 commits into from
Jul 10, 2021

Conversation

nekosaur
Copy link
Member

Description

fixes #13893 with computed instead of reactive

Motivation and Context

keeps code base consistent, and adds test

How Has This Been Tested?

cy test and playground

Markup:

<template>
  <v-app>
    <v-list
      lines="three"
      max-width="500"
      theme="dark"
    >
      <v-list-item
        v-for="n in 3"
        :key="n"
        title="Three line item"
        :active="n === model"
        subtitle="lorem"
        active-color="success"
        text="text"
        @click="model = n"
      />
    </v-list>
  </v-app>
</template>

<script>
  export default {
    name: 'Playground',
    data: () => ({
      model: 1,
    }),
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

nekosaur added 2 commits July 10, 2021 13:07
this uses computed instead of reactive, and adds a test

fixes #13893
@nekosaur nekosaur merged commit 7e75cf9 into next Jul 10, 2021
@nekosaur nekosaur deleted the fix/list-item-active-color branch July 10, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants