Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] Can't select text at v-list-item on safari #12826

Closed
NikitaKovtun opened this issue Dec 23, 2020 · 2 comments
Closed

[Bug Report] Can't select text at v-list-item on safari #12826

NikitaKovtun opened this issue Dec 23, 2020 · 2 comments
Assignees
@johnleider
Labels
C: VList good first issue A quick-win fix that would be great for new contributors help wanted We are looking for community help platform specific The issue only occurs on a specific platform T: bug Functionality that does not work as intended/expected Vuetify 3 - Phase 2
Milestone
v3.0.0

Comments

@NikitaKovtun
Copy link

Environment

Vuetify Version: 2.3.16
Vue Version: 2.6.12
Browsers: Safari 14.0
OS: Mac OS 10.15.7

Steps to reproduce

Just try select part of text with mouse

Expected Behavior

Selected part of text

Actual Behavior

not selected text

Reproduction Link

https://codepen.io/nikitakovtun/pen/MWjEORY
@ghost ghost added the S: triage label Dec 23, 2020
@KaelWD KaelWD added C: VList good first issue A quick-win fix that would be great for new contributors help wanted We are looking for community help platform specific The issue only occurs on a specific platform T: bug Functionality that does not work as intended/expected and removed S: triage labels Dec 23, 2020
@KaelWD KaelWD changed the title [Bug Report] Can't select text at v-list-item [Bug Report] Can't select text at v-list-item on safari Dec 23, 2020
@Altantur
Copy link

Altantur commented Jan 7, 2021

Just digging around, cause of this bug is tabindex="-1".

<div tabindex="-1" role="listitem" class="v-list-item theme--light">
...
</div>

If we remove tabindex attribute like below, selecting text on Safari works.

<div role="listitem" class="v-list-item theme--light">
...
</div>

I know it is not a solution, but it is better to exclude for Safari since tab-access is disabled by default.

Altantur added a commit to Altantur/vuetify that referenced this issue Jan 7, 2021
@Altantur
fix(VListItem): preventing on Safari Desktop adding tabindex attribute
cc36a59 
fixes vuetifyjs#12826
@Altantur Altantur mentioned this issue Jan 7, 2021
Closed
8 tasks
@johnleider johnleider added this to the v3.0.0 milestone Jun 8, 2021
@johnleider
Copy link
Member

This is resolved by #13697.

If you have any questions, please reach out to us in our Discord community.

@johnleider johnleider self-assigned this Jun 14, 2021
johnleider added a commit that referenced this issue Jun 14, 2021
@johnleider @KaelWD
feat(VList): port to v3 (#13697)
be331bf 
fixes #8137
fixes #9285
fixes #12826

Co-authored-by: Kael <[email protected]>
johnleider added a commit that referenced this issue Jun 14, 2021
@johnleider @KaelWD
feat(VList): port to v3 (#13697)
e6e6b64 
fixes #8137
fixes #9285
fixes #12826

Co-authored-by: Kael <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnleider johnleider

Labels
C: VList good first issue A quick-win fix that would be great for new contributors help wanted We are looking for community help platform specific The issue only occurs on a specific platform T: bug Functionality that does not work as intended/expected Vuetify 3 - Phase 2
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

fix(VListItem): preventing on Safari Desktop adding tabindex attribute Altantur/vuetify
4 participants
@Altantur @johnleider @KaelWD @NikitaKovtun