Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(TF-408): how deployment works #7400

Merged
merged 4 commits into from
Feb 25, 2025
Merged

docs(TF-408): how deployment works #7400

merged 4 commits into from
Feb 25, 2025
+135 −2

Conversation

jagoral
Copy link
Contributor

@jagoral jagoral commented Feb 19, 2025

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 19, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6f91dde

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jagoral jagoral requested review from grixu, filrak and mateuszo February 19, 2025 12:08
@jagoral jagoral force-pushed the docs/tf-408-how-deployment-works branch from be6881b to 337ef1d Compare February 19, 2025 12:12
@jagoral jagoral force-pushed the docs/tf-408-how-deployment-works branch from 337ef1d to 84716b4 Compare February 19, 2025 12:14
grixu
grixu approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@grixu grixu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice story, great to read! 🔥

mateuszo
mateuszo approved these changes Feb 21, 2025
View reviewed changes
docs/content/guides/6.multistore/2.tooling-and-concepts/4.deployment/6.deployment.md Outdated
│ │ ├── eu/
```

The CLI copies files to their respective store directories, creating a fully independent version of each store:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might not be clear what "independent version" means. I'd write explicitly that they are separate next/nuxt projects / source code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point 6f91dde

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jagoral jagoral merged commit 00d61a0 into docs/multibrand Feb 25, 2025
3 checks passed
@jagoral jagoral deleted the docs/tf-408-how-deployment-works branch February 25, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszo mateuszo mateuszo approved these changes

@filrak filrak filrak approved these changes

@grixu grixu grixu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jagoral @mateuszo @filrak @grixu