chore: migrate nuxt module to HMR version #3232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Szymon-dziewonski
requested review from
FRSgit,
mattmaribojoc and
filrak
as code owners
🦋 Changeset detectedLatest commit: 79406be The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Szymon-dziewonski
force-pushed
the
chore--migrate-nuxt-module-to-hmr-version
branch
from
46e682f to
885d863
Compare
Szymon-dziewonski
force-pushed
the
chore--migrate-nuxt-module-to-hmr-version
branch
from
885d863 to
15d6ddb
Compare
dawid-ziobro
reviewed
Oct 8, 2024
apps/docs/components/package.json
Outdated
| "nuxt": "^3.12.4", | ||
| "nuxt-gtag": "^2.1.0" | ||
| "nuxt": "^3.13.2", | ||
| "nuxt-gtag": "^2.0.5" |
There was a problem hiding this comment.
I havent changed this version of nuxt-gtag, weird, yarn had to change it, good catch will check it
FRSgit
reviewed
Oct 8, 2024
Comment on lines
+1
to
+4
| // How to test? check if variable is overwritten with current priority table | ||
| // 1. `tailwind.config.ts` file | ||
| // 2. `nuxt.config.ts` file with `tailwindcss` property | ||
| // 3. default configuration inside module |
FRSgit
approved these changes
Oct 8, 2024
Szymon-dziewonski
deleted the
chore--migrate-nuxt-module-to-hmr-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #
Scope of work
Newest version
@nuxtjs/tailwindicss:6.12.1that supports HMR our module has to migratedConnected GH issue nuxt-modules/tailwindcss#898 (comment)
Screenshots of visual changes
Checklist