Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: inheritance attribute for react icons [SFUI2-1243] #3005

Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix: inheritance attribute for react icons [SFUI2-1243] #3005

merged 1 commit into from
Oct 4, 2023

Conversation

Szymon-dziewonski
Copy link
Contributor

@Szymon-dziewonski Szymon-dziewonski commented Oct 4, 2023 •
edited
Loading

Related issue

https://vsf.atlassian.net/browse/SFUI2-1243

Scope of work

Fix inheritance of attributes in icon components, now there is possibility to overwrite e.g xmlns or viewBox attributes

Screenshots of visual changes

Checklist

  • Self code-reviewed
  • Changes documented
  • Semantic HTML
  • SSR-friendly
  • Caching friendly
  • a11y for WCAG 2.0 AA
  • examples created
  • blocks created
  • cypress tests created

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 26b2039

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@storefront-ui/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Szymon-dziewonski Szymon-dziewonski force-pushed the fix--icon-inheritance-attrs branch from 7c7121f to 8f75007 Compare October 4, 2023 13:08
@Szymon-dziewonski Szymon-dziewonski force-pushed the fix--icon-inheritance-attrs branch from 8f75007 to 26b2039 Compare October 4, 2023 13:27
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

[storefront-ui-react] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

[storefront-ui-vue] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@Szymon-dziewonski Szymon-dziewonski merged commit e82aa92 into v2-develop Oct 4, 2023
@Szymon-dziewonski Szymon-dziewonski deleted the fix--icon-inheritance-attrs branch October 4, 2023 15:25
@github-actions github-actions bot mentioned this pull request Oct 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRSgit FRSgit FRSgit approved these changes

@dkacper dkacper Awaiting requested review from dkacper

@mattmaribojoc mattmaribojoc Awaiting requested review from mattmaribojoc mattmaribojoc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Szymon-dziewonski @FRSgit