Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SfScrollable): floating disabled state, refactor [SFUI2-1301 #2936

Merged
merged 1 commit into from
Jul 25, 2023
Merged

fix(SfScrollable): floating disabled state, refactor [SFUI2-1301 #2936

merged 1 commit into from
Jul 25, 2023

Conversation

Szymon-dziewonski
Copy link
Contributor

@Szymon-dziewonski Szymon-dziewonski commented Jul 25, 2023 •
edited
Loading

Related issue

https://vsf.atlassian.net/browse/SFUI2-1301

Scope of work

  • unify styling in react and vue
  • fix not assigning composable getPrevButtonProps and getNextButtonProps for disabled attribute
  • change behavior so it would match figma, hiding buttons floating for buttonsPlacement

Screenshots of visual changes

Checklist

  • Self code-reviewed
  • Changes documented
  • Semantic HTML
  • SSR-friendly
  • Caching friendly
  • a11y for WCAG 2.0 AA
  • examples created
  • blocks created
  • cypress tests created

@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 411e0fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@storefront-ui/react Patch
@storefront-ui/vue Patch
@storefront-ui/nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Szymon-dziewonski Szymon-dziewonski force-pushed the fix--sfscrollable-disable-state-floating branch from fc789ac to bf3f32b Compare July 25, 2023 09:53
@Szymon-dziewonski Szymon-dziewonski force-pushed the fix--sfscrollable-disable-state-floating branch from bf3f32b to 411e0fb Compare July 25, 2023 10:23
@sonarqubecloud
Copy link

[storefront-ui-vue] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[storefront-ui-react] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Szymon-dziewonski Szymon-dziewonski merged commit 6bf2b3f into v2-develop Jul 25, 2023
@Szymon-dziewonski Szymon-dziewonski deleted the fix--sfscrollable-disable-state-floating branch July 25, 2023 10:48
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
Closed
Szymon-dziewonski added a commit that referenced this pull request Oct 2, 2023
@Szymon-dziewonski
fix(SfScrollable): floating disabled state, refactor (#2936)
20df3e9
@github-actions github-actions bot mentioned this pull request Oct 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRSgit FRSgit FRSgit approved these changes

@dkacper dkacper Awaiting requested review from dkacper

@mattmaribojoc mattmaribojoc Awaiting requested review from mattmaribojoc mattmaribojoc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Szymon-dziewonski @FRSgit