Skip to content

Commit

Permalink
fix: importing types from a local file instead of the package in SfBa…
Browse files Browse the repository at this point in the history
…dge (#2939)

---------
Co-authored-by: Szymon Dziewoński <[email protected]>
  • Loading branch information
filrak authored Aug 17, 2023
1 parent f8fc887 commit d57c3cf
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 7 deletions.
5 changes: 5 additions & 0 deletions .changeset/fast-pugs-warn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@storefront-ui/react': patch
---

Import types from package in SfBadge
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { SfBadgePlacement } from '@storefront-ui/shared';
import classNames from 'classnames';
import type { SfBadgeProps } from './types';
import type { SfBadgeProps } from '@storefront-ui/react';

export default function SfBadge({
content,
Expand Down
4 changes: 2 additions & 2 deletions packages/sfui/frameworks/react/components/SfBadge/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
export { default as SfBadge } from './SfBadge';

export * from './types';

export { default as SfBadge } from './SfBadge';
4 changes: 2 additions & 2 deletions packages/sfui/frameworks/react/components/SfRadio/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
export { default as SfRadio } from './SfRadio';

export * from './types';

export { default as SfRadio } from './SfRadio';
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
export { default as SfRatingButton } from './SfRatingButton';

export * from './types';

export { default as SfRatingButton } from './SfRatingButton';

0 comments on commit d57c3cf

Please sign in to comment.