Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor errors in README.md #1523

Merged
merged 3 commits into from
Mar 17, 2019
Merged

Fix minor errors in README.md #1523

merged 3 commits into from
Mar 17, 2019

Conversation

dollinad
Copy link
Contributor

Changes involve:

  • Removal of dead links: data flow.png and vuex.png
  • Removal of discourse markers (although, also, in addition) to make sentences precise

Changes involve:
- Removal of dead links: data flow.png and vuex.png
- Removal of discourse markers (although, also, in addition) to make sentences precise
@ktsn
Copy link
Member

ktsn commented Mar 17, 2019

Removal of dead links

Well, it's not dead links actually. https://vuex.vuejs.org/

Re-added link for Vuex
@dollinad
Copy link
Contributor Author

Updated!

Re-added link https://vuex.vuejs.org/

@ktsn
Copy link
Member

ktsn commented Mar 17, 2019

I mean flow.png and vuex.png is not dead links. Could you restore them?
You can see the rendered docs of this PR in https://deploy-preview-1523--vuex-docs.netlify.com/ or by npm run docs in your local.

Readded flow.png and veux.png
@ktsn ktsn merged commit d072724 into vuejs:dev Mar 17, 2019
ktsn added a commit that referenced this pull request Mar 17, 2019
@ktsn
Copy link
Member

ktsn commented Mar 17, 2019

Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants