-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid possible infinite loop by accessing observables in error handler (fix vuex#1505) #9489
Merged
yyx990803
merged 1 commit into
vuejs:dev
from
ktsn:avoid-infinite-render-error-captured
Feb 18, 2019
Merged
fix: avoid possible infinite loop by accessing observables in error handler (fix vuex#1505) #9489
yyx990803
merged 1 commit into
vuejs:dev
from
ktsn:avoid-infinite-render-error-captured
Feb 18, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 29, 2019
This was referenced Sep 22, 2019
Lostlover
pushed a commit
to Lostlover/vue
that referenced
this pull request
Dec 10, 2019
This was referenced Jan 20, 2020
This was referenced Feb 24, 2020
This was referenced Mar 4, 2020
This was referenced Apr 15, 2020
This was referenced May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix vuejs/vuex#1505
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch for v2.x (or to a previous version branch), not themaster
branchfix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
The original issue is vuejs/vuex#1505
When we touch some observables in
errorCaptured
hook, it is registered as dependency of the rendered component. Then the infinite rendering loop happens if we update the value inside the hook.Updated reproduction which does not have Vuex store is here. https://codesandbox.io/s/ypvy7zn9xx