refactor: add empty v-bind warning(re #7973) #7988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
requested changes
Apr 9, 2018
src/compiler/parser/index.js
Outdated
| ) { | ||
| warn( | ||
| `${name}="${value}": ` + | ||
| 'The v-bind expression should not be empty' |
There was a problem hiding this comment.
I think we can improve the message to something like the value for a v-bind expression cannot be empty. Found in '${name}'.
Let's wait for others feedback as I am not native
There was a problem hiding this comment.
thanks, I will do it later
| @@ -508,6 +508,7 @@ describe('parser', () => { | |||
| expect(ast.attrs[1].value).toBe('"field1"') | |||
| expect(ast.props[0].name).toBe('value') | |||
| expect(ast.props[0].value).toBe('msg') | |||
| expect('The v-bind expression should not be empty').toHaveBeenWarned() | |||
There was a problem hiding this comment.
Let's extract this into one single test
lyhper
force-pushed
the
add-compile-warning
branch
from
2cc2965 to
dd4f92a
Compare
lyhper
force-pushed
the
add-compile-warning
branch
from
dd4f92a to
45a4744
Compare
|
@posva Is it ok? |
|
yeah, we will just wait for a native to chime in to improve the warning message 🙂 |
|
thank you 😀 |
|
The warning message sounds good to me as a native speaker 👍 |
posva
approved these changes
Apr 11, 2018
wistcc
reviewed
May 26, 2018
| @@ -528,6 +528,14 @@ function processAttrs (el) { | |||
| name = name.replace(bindRE, '') | |||
| value = parseFilters(value) | |||
| isProp = false | |||
| if ( | |||
| process.env.NODE_ENV !== 'production' && | |||
There was a problem hiding this comment.
I think we should check all environments instead of just production.
f2009
pushed a commit
to f2009/vue
that referenced
this pull request
Jan 25, 2019
* refactor: add empty v-bind warnings re vuejs#7973 * Update index.js
aJean
pushed a commit
to aJean/vue
that referenced
this pull request
Aug 19, 2020
* refactor: add empty v-bind warnings re vuejs#7973 * Update index.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: