Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runtime-vapor): mounted & unmounted hook #46

Merged
merged 6 commits into from
Dec 14, 2023

Conversation

GaoNeng-wWw
Copy link
Contributor

image

^^ source code

vvv result

1

I reopen a new pull request. Because I messed up when resolving the conflict

@ubugeeei ubugeeei mentioned this pull request Dec 10, 2023
12 tasks
@ubugeeei ubugeeei requested a review from sxzz December 10, 2023 04:48
@ubugeeei ubugeeei added the enhancement New feature or request label Dec 10, 2023
@ubugeeei
Copy link
Member

@GaoNeng-wWw
Thank you for submitting the new one! And I'm sorry for the conflict.
Since this R&D is still in the phase where a small amount of source code is being modified by multiple people,
conflicts occur frequently. 😅

@sxzz
Please check this comment from the previous PR!
#43 (comment)

@GaoNeng-wWw
Copy link
Contributor Author

Thank you for submitting the new one! And I'm sorry for the conflict.
Since this R&D is still in the phase where a small amount of source code is being modified by multiple people,
conflicts occur frequently. 😅

It's my lack of familiarity with Git that caused this, there's no need for you to apologize for it. 👀

@sxzz sxzz force-pushed the feat/mounted-hook branch from 253886b to d6d363b Compare December 14, 2023 17:32
Copy link

github-actions bot commented Dec 14, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 88.2 kB 33.6 kB 30.3 kB
runtime-vapor.global.prod.js 20.1 kB (+888 B) 7.67 kB (+382 B) 7.04 kB (+336 B)
vue-vapor.global.prod.js 55.6 kB (+887 B) 18.8 kB (+379 B) 17 kB (+341 B)
vue.global.prod.js 145 kB 52.7 kB 47.1 kB

Usages

Name Size Gzip Brotli
createApp 48.8 kB 19.1 kB 17.5 kB
createSSRApp 52 kB 20.5 kB 18.7 kB
defineCustomElement 51.2 kB 19.9 kB 18.2 kB
vapor 20 kB (+873 B) 7.68 kB (+387 B) 7.06 kB (+346 B)
overall 62.2 kB 24 kB 21.9 kB

@sxzz sxzz merged commit 9d3abcf into vuejs:main Dec 14, 2023
@GaoNeng-wWw GaoNeng-wWw deleted the feat/mounted-hook branch January 7, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants