Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement setRef update #191

Merged
merged 10 commits into from
Apr 30, 2024
Merged

feat: implement setRef update #191

merged 10 commits into from
Apr 30, 2024

Conversation

Doctor-wu
Copy link
Member

  • runtime
  • test case

close #190

Copy link

netlify bot commented Apr 26, 2024

Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit fedc46f
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/662e5a5ceb9dde00085ec3fa
😎 Deploy Preview https://deploy-preview-191--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 26, 2024

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit fedc46f
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/662e5a5cca87580008bde011
😎 Deploy Preview https://deploy-preview-191--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Doctor-wu Doctor-wu mentioned this pull request Apr 26, 2024
28 tasks
@Doctor-wu Doctor-wu requested a review from sxzz April 26, 2024 15:50
Copy link

github-actions bot commented Apr 26, 2024

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 80.1 kB 28.2 kB 24.7 kB
compiler-vapor.global.prod.js 52.6 kB (+246 B) 18 kB (+90 B) 16.3 kB (+54 B)
runtime-dom.global.prod.js 94.7 kB 35.6 kB 32.2 kB
runtime-vapor.global.prod.js 45 kB (+87 B) 16.8 kB (+38 B) 15.4 kB (+29 B)
vue-vapor.global.prod.js 95 kB (+293 B) 33.3 kB (+111 B) 30.1 kB (+125 B)
vue.global.prod.js 152 kB 55 kB 49.1 kB

Usages

Name Size Gzip Brotli
createApp 54.8 kB 21.1 kB 19.2 kB
createSSRApp 58.1 kB 22.4 kB 20.4 kB
defineCustomElement 57.1 kB 21.8 kB 19.8 kB
vapor 45.2 kB (+87 B) 16.8 kB (+37 B) 15.4 kB (+36 B)
overall 68.5 kB 26.1 kB 23.7 kB

Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactored a bit. We can omit the latest undefined param.

@Doctor-wu Doctor-wu requested a review from sxzz April 28, 2024 14:59
@sxzz
Copy link
Member

sxzz commented Apr 30, 2024

Good job!

@sxzz sxzz merged commit 6958051 into main Apr 30, 2024
11 checks passed
@sxzz sxzz changed the title feat(runtime-vapor, compiler-vapor): impl setRef update feat: implement setRef update Apr 30, 2024
@sxzz sxzz deleted the feature-ref-update branch April 30, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setRef update
2 participants