Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runtime-vapor): template ref on component #185

Merged
merged 6 commits into from
Apr 24, 2024
Merged

Conversation

Doctor-wu
Copy link
Member

@Doctor-wu Doctor-wu commented Apr 20, 2024

impl ref on component close #184

  • runtime
  • test case

Copy link

netlify bot commented Apr 20, 2024

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit b3ad1c9
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/6629153b5dc3640008975762
😎 Deploy Preview https://deploy-preview-185--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 20, 2024

Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit b3ad1c9
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/6629153b35b3a90009878120
😎 Deploy Preview https://deploy-preview-185--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Apr 20, 2024

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 80.1 kB 28.2 kB 24.7 kB
compiler-vapor.global.prod.js 52.2 kB 17.8 kB 16.2 kB
runtime-dom.global.prod.js 94.7 kB 35.6 kB 32.2 kB
runtime-vapor.global.prod.js 43.2 kB (+39 B) 16.1 kB (+19 B) 14.7 kB (+14 B)
vue-vapor.global.prod.js 92.8 kB (+39 B) 32.5 kB (+19 B) 29.3 kB (+40 B)
vue.global.prod.js 152 kB 55 kB 49.1 kB

Usages

Name Size Gzip Brotli
createApp 54.9 kB 21.1 kB 19.2 kB
createSSRApp 58.2 kB 22.4 kB 20.4 kB
defineCustomElement 57.2 kB 21.8 kB 19.9 kB
vapor 43.4 kB (+39 B) 16.1 kB (+18 B) 14.7 kB (+26 B)
overall 68.6 kB 26.1 kB 23.6 kB

@Doctor-wu Doctor-wu marked this pull request as ready for review April 20, 2024 15:50
@Doctor-wu Doctor-wu requested a review from sxzz April 20, 2024 15:50
@Doctor-wu Doctor-wu mentioned this pull request Apr 21, 2024
28 tasks
packages/runtime-vapor/src/component.ts Outdated Show resolved Hide resolved
packages/runtime-vapor/src/dom/templateRef.ts Outdated Show resolved Hide resolved
packages/runtime-vapor/src/dom/templateRef.ts Outdated Show resolved Hide resolved
packages/runtime-vapor/__tests__/dom/templateRef.spec.ts Outdated Show resolved Hide resolved
@Doctor-wu Doctor-wu requested a review from sxzz April 24, 2024 03:38
@sxzz sxzz merged commit b7b652e into main Apr 24, 2024
11 checks passed
@sxzz sxzz changed the title feat(runtime-vapor): impl ref on component feat(runtime-vapor): template ref on component Apr 24, 2024
@sxzz sxzz deleted the feature-ref-on-component branch April 24, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component setRef
2 participants