feat(runtime-vapor): createSlot
#170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vapor-template-explorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for vapor-repl ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size ReportBundles
Usages
|
LittleSound
force-pushed
the
feat/runtime-vapor-createSlot
branch
from
dccd6e3 to
6c99c7a
Compare
sxzz
approved these changes
Apr 12, 2024
| : slot.fn, | ||
| ) | ||
| dynamicSlotKeys[slot.name] = true | ||
| renderEffect(() => { |
There was a problem hiding this comment.
Why change here? slots can be accessed by public API useSlots. So we need to update it before effects from user-land. Just like attrs
There was a problem hiding this comment.
When making the modification, I did not take this situation into account, but I have now corrected it.
Maybe we can add a unit test for this feature later?
sxzz
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #154 (comment)