-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(setData): allow empty objects to be set fix #1704 #1705
Conversation
fixes vuejs#1704 This is a tentative fix to show one possible solution, I can clean it up if you think it makes sense
Seems like some tests are failing. LMK if I can help out with anything. |
I didn't update the tests yet, but I'm more wondering if my approach makes sense, and whether this is a problem that should even be fixed @lmiller1990 :) |
I guess so, if Vue supports this (which it does, right, settings something in data to |
Tests are passing now, although I didn't add a new test for this yet :) |
Great. Can you add a test for this, too? Then we can merge it. |
voilà @lmiller1990, new test added :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Thanks for your reactivity all 👍 |
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
if someone relied on empty objects not updating, that now no longer makes sense
The PR fulfills these requirements:
dev
branch.fix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
This is a tentative fix to show one possible solution, I can clean it up if you think it makes sense