make a copy when query param value is an array (fix #1182) #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
reviewed
Apr 3, 2017
| } | ||
| return parsedQuery | ||
| } else { | ||
| return extraQuery |
There was a problem hiding this comment.
It worries me that deleting this part didn't break the test. @fnlctrl Do you have an idea about this?
There was a problem hiding this comment.
There is already an empty value check in parseQuery function.
There was a problem hiding this comment.
Yeah, but in the other case we were skipping the whole parseQuery and for loop and returning right away the extraQuery instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1182
Don't using the object reference as query value directly.