refactor!: replace module.exports with ES module export #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the emitted TypeScript type definitions Closes vuejs#1667.
yyx990803
reviewed
May 11, 2020
| @@ -38,7 +40,10 @@ export interface VueLoaderOptions { | |||
|
|
|||
| let errorEmitted = false | |||
|
|
|||
| const loader: webpack.loader.Loader = function(source: string) { | |||
| export default function loader( | |||
There was a problem hiding this comment.
This would require require('vue-loader').default? Does webpack have built-in esModule default interop?
There was a problem hiding this comment.
Yeah, webpack uses loader-runner to run loaders, and it supports .default https://github.com/webpack/loader-runner/blob/master/lib/loadLoader.js#L26
Or we can provide another .cjs entry if compatibility is a concern.
But I don't think it's necessary, as vue-loader is only supposed to be called by webpack.
yyx990803
requested changes
May 11, 2020
yyx990803
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the emitted TypeScript type definitions
Closes #1667.