Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce recreate ts program when no need for ts perf #2328

Merged
merged 3 commits into from
Oct 29, 2020
Merged

Reduce recreate ts program when no need for ts perf #2328

merged 3 commits into from
Oct 29, 2020

Conversation

yoyo930021
Copy link
Member

@yoyo930021 yoyo930021 commented Sep 25, 2020 •
edited
Loading

Improve a part of #2192, #2163

This change reduce VTI run time by half.

gtime result

old:
834.59 user 29.64 system 11:21.12 elapsed 126% CPU (0avgtext+0avgdata 1409020maxresident)k

new:
422.72 user 12.04 system 6:04.27 elapsed 119% CPU (0avgtext+0avgdata 1221284maxresident)k

but this PR is dangerous, I will observe for a while in local.

@yoyo930021 yoyo930021 marked this pull request as draft September 25, 2020 10:06
@yoyo930021 yoyo930021 changed the title Improve typescript pref Improve ts language service pref Sep 25, 2020
@yoyo930021 yoyo930021 mentioned this pull request Sep 25, 2020
Closed
@yoyo930021 yoyo930021 changed the title Improve ts language service pref Improve ts language service perf Sep 25, 2020
@yoyo930021 yoyo930021 mentioned this pull request Sep 25, 2020
Closed
3 tasks
@yoyo930021 yoyo930021 changed the title Improve ts language service perf Reduce recreate ts program for improve ts perf Sep 25, 2020
@yoyo930021 yoyo930021 changed the title Reduce recreate ts program for improve ts perf Reduce recreate ts program for ts perf Sep 26, 2020
@yoyo930021 yoyo930021 changed the title Reduce recreate ts program for ts perf Reduce recreate ts program when no need for ts perf Sep 26, 2020
@yoyo930021
Copy link
Member Author

I think it's great when short time test.
I will observe it more time.

@yoyo930021
Copy link
Member Author

Ref: #2192 (comment)

@yoyo930021 yoyo930021 marked this pull request as ready for review October 5, 2020 10:23
@yoyo930021 yoyo930021 mentioned this pull request Oct 5, 2020
Open
3 tasks
@yoyo930021 yoyo930021 mentioned this pull request Oct 16, 2020
Merged
octref
octref approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@octref octref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for finding this!

@octref octref merged commit 97deb35 into vuejs:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octref octref octref approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoyo930021 @octref