types(watch): support single usage of defineModel with watch #9940
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
pikax
added
scope: types
🔨 p3-minor-bug
|
Sorry, I didn't find that you have created this PR. I found in #9942 that adjusting the order of overloads can solve this problem, which can reduce unnecessary overloads. Of course, I don't know if my solution in #9942 is reasonable. If you think it is better to add an overload, I can turn close #9942. |
|
I think #9942 is simpler than adding a dedicated overload. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9939
Because
ModelRefis also an array it falls through the array sources, even tho it shouldn't be handled as an array in this case