Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compile-core): allow flexible spacing in v-for #9576

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jh-leong
Copy link
Member

@jh-leong jh-leong commented Nov 9, 2023

Close #6499.

Previously, spaces around 'of' were required, but with this change, it is now possible to write v-for without the spaces.

Copy link

github-actions bot commented Nov 9, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB 38.1 kB 34.2 kB
vue.global.prod.js 160 kB (+98 B) 58 kB (+41 B) 51.5 kB (+3 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 49.1 kB 18.9 kB 17.3 kB
createApp 55.7 kB 21.4 kB 19.6 kB
createSSRApp 59.7 kB 23.1 kB 21 kB
defineCustomElement 60.4 kB 23 kB 20.9 kB
overall 69.4 kB 26.5 kB 24.1 kB

baiwusanyu-c

This comment was marked as outdated.

@baiwusanyu-c
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Nov 16, 2023

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success success
pinia success success
quasar success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify failure failure
vueuse success success
vue-simple-compiler success success

@pikax pikax added the 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. label Nov 22, 2023
@jh-leong jh-leong requested a review from baiwusanyu-c May 23, 2024 02:31
@jh-leong
Copy link
Member Author

The changes in this PR have fixed #5819. Updated the test cases to reflect this fix.

@yyx990803 yyx990803 added 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. and removed 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Jun 7, 2024
@edison1105 edison1105 added the ready to merge The PR is ready to be merged. label Oct 9, 2024
Copy link

pkg-pr-new bot commented Oct 9, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@9576

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@9576

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@9576

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@9576

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@9576

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@9576

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@9576

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@9576

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@9576

vue

pnpm add https://pkg.pr.new/vue@9576

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@9576

commit: ac390a6

@edison1105 edison1105 changed the title feat(compiler): allow flexible spacing in v-for feat(compile-core): allow flexible spacing in v-for Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged. scope: compiler
Projects
Status: Needs Review
Development

Successfully merging this pull request may close these issues.

Allow omit space around of in v-for
7 participants