fix(setup): returning render function breaks when extending with an empty object
#383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! Does this mean that this will now work as expected without any changes to VTU? |
|
Yes, this should make it work without any changes to VTU |
This was referenced Jun 16, 2020
|
Thank you very much for taking the time to fix this! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #151
Fix the bug when returning render function:
Vue.extend(Comp).extend({}) - vue-test-utilsThe bug is caused because we try to merge the
functionwith an empty object.vuejs/vue-test-utils#1512 can be reopen and merged after we release this
also fix vuejs/vue-test-utils#1484