Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: PropType not working on some types #555

Closed
Mister-Hope opened this issue Oct 8, 2020 · 4 comments · Fixed by #561
Closed

Bug: PropType not working on some types #555

Mister-Hope opened this issue Oct 8, 2020 · 4 comments · Fixed by #561
Labels
bug Something isn't working typing

Comments

@Mister-Hope
Copy link
Contributor

Mister-Hope commented Oct 8, 2020 •
edited
Loading

Vue3:

image

composition-api:

image

Could this be fixed?
@antfu antfu added bug Something isn't working typing labels Oct 8, 2020
@Mister-Hope Mister-Hope changed the title Quesstion: PropType not working on some types Bug: PropType not working on some types Oct 14, 2020
@posva posva mentioned this issue Oct 14, 2020
Merged
antfu pushed a commit that referenced this issue Oct 17, 2020
@Mister-Hope
fix(types): prop type infer, fix #555 (#561)
35f8fec
@IndexXuan
Copy link
Contributor

@Mister-Hope
Bro, PropType<'foo' | 'bar'> works but PropType<1 | 2> still not working, just number result

@Mister-Hope
Copy link
Contributor Author

Mister-Hope commented Nov 9, 2020 •
edited
Loading

@Mister-Hope
Bro, PropType<'foo' | 'bar'> works but PropType<1 | 2> still not working, just number result

I am on the road now. Could you try it in Vue3 and see if it works?

@Mister-Hope
Copy link
Contributor Author

Mister-Hope commented Nov 9, 2020 •
edited
Loading

Hey bro @IndexXuan I ask a friend to test it for me.

image
image
image

It seems that it's working well, both on this plugin and Vue3

@IndexXuan
Copy link
Contributor

@Mister-Hope amazing, it works, thanks a lot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(types): prop type infer, fix #555
3 participants
@IndexXuan @antfu @Mister-Hope