Fix: improvised attack rolls issue #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RabidOwlbear
pushed a commit
to RabidOwlbear/ose
that referenced
this pull request
Jan 24, 2022
* fix(character sheet): fixed MEL/MIS roll buttons * chore(build): build to make PR test easier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug reported on Discord noted that Clicking MEL or MIS (attributes tab) returns the following errors in OSE 1.3.3.
I reproduced on 0.8.9 and V9. Since these buttons are primarily used for improvised attacks without a designated weapon, I deduced that a change we made to make Automated Animations work(#29), which requires some info about the Weapon being used, is now causing an error when not using a weapon ( _id not found). Optional chaining when getting the item id appears to fix the error