-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and fixes for the Party Sheet #36
Merged
anthonyronda
merged 10 commits into
vttred:main
from
freohr:feature/add-dragdrop-to-party-sheet
Jan 17, 2022
Merged
Refactor and fixes for the Party Sheet #36
anthonyronda
merged 10 commits into
vttred:main
from
freohr:feature/add-dragdrop-to-party-sheet
Jan 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove all components used for the party select modal as well
No worries! Reviewing now |
anthonyronda
approved these changes
Jan 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Works well in testing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, if we ever put up the site with the quick overview of the system, the part about the Party Overview has been updated to match the changes done in this PR.
P.S.: Sorry about the full reformat of the help page, I just manually saved the page in VSCode which triggered the reformat >.>