Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and fixes for the Party Sheet #36

Merged
merged 10 commits into from
Jan 17, 2022

Conversation

freohr
Copy link
Collaborator

@freohr freohr commented Jan 16, 2022

  • Replaces the actor selection modal with drag&drop from the sidebar (as well as a small button to remove Actor from the Party).
  • Enable dragging actors from the Party Sheet (e.g. to put them on a scene)
  • Fix the rendering synchronization of the party sheet when updating who is in the party (on all currently connected clients)
    • Which means that the now obsolete "sync" button has been removed
  • Small refactor of the XP modal
    • Auto calculate XP shares on input (instead of having to click on the button, which has been removed)
    • Close the XP modal on submit

Also, if we ever put up the site with the quick overview of the system, the part about the Party Overview has been updated to match the changes done in this PR.

P.S.: Sorry about the full reformat of the help page, I just manually saved the page in VSCode which triggered the reformat >.>

@anthonyronda anthonyronda self-requested a review January 16, 2022 20:16
@anthonyronda
Copy link
Member

Sorry about the full reformat of the help page, I just manually saved the page in VSCode which triggered the reformat >.>

No worries! Reviewing now

Copy link
Member

@anthonyronda anthonyronda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Works well in testing!

@anthonyronda anthonyronda merged commit a8e957c into vttred:main Jan 17, 2022
@freohr freohr deleted the feature/add-dragdrop-to-party-sheet branch January 17, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants