Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/display tags item directory #119

Merged
merged 3 commits into from
Feb 23, 2022
Merged

Fix/display tags item directory #119

merged 3 commits into from
Feb 23, 2022

Conversation

freohr
Copy link
Collaborator

@freohr freohr commented Feb 23, 2022

I moved the tag list block, displaying information in the item summary, to a template, and used that template to fix the display of tags in the sidebar directories

@anthonyronda
Copy link
Member

Thank you! Tracked in #117

@anthonyronda anthonyronda self-requested a review February 23, 2022 16:18
@freohr freohr linked an issue Feb 23, 2022 that may be closed by this pull request
Regression: tags are not being displayed on the items in the sidebar directories #117
Closed
anthonyronda
anthonyronda approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@anthonyronda anthonyronda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anthonyronda anthonyronda merged commit 5ff920a into vttred:main Feb 23, 2022
@freohr freohr deleted the fix/display-tags-item-directory branch February 26, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonyronda anthonyronda anthonyronda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression: tags are not being displayed on the items in the sidebar directories
2 participants
@freohr @anthonyronda