This repository was archived by the owner on Apr 9, 2021. It is now read-only.
Bumpup update vscode-html-languageserver to 8637f10dd31c677acfe4c3a0e5f91c457aa7a00a #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DeltaEvo gentle ping |
vscode-html-languageserver's tsconfig changed. It extends `../../shared.tsconfig.json` that is `https://github.com/microsoft/vscode/blob/master/extensions/shared.tsconfig.json` now. So I copy and use shared.tsconfig.json. I don't want to keep up with changes in shared.tsconfig.json, but I couldn't think of any other easy way. The submodule directory has also been changed to match the relative path of extends in tsconfig.json.
|
Would be nice if the npm version gets updated after this gets merged too. It is two years old. |
|
While we are waiting for this pull request to be merged, @h-michael can you please provide me steps to compile your branch and generate a binary for use with my text editor? Thanks |
…3a0e5f91c457aa7a00a
h-michael
changed the title
|
@CSRaghunandan you can build by |
|
@aeschli Would you review this PR? |
|
@h-michael You need to ask a maintainer of this repo. |
|
I will review it, I'm just a little busy and I need to take time to test it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vscode-html-languageserver's tsconfig changed.
It extends
../../shared.tsconfig.jsonthat ishttps://github.com/microsoft/vscode/blob/master/extensions/shared.tsconfig.jsonnow.So I've changed submodule directory and build.js.
If this method is acceptable, put the same modifications in vscode-json-languageserver-bin and vscode-css-languageserver-bin.