Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove depthfirstscheduler #750

Merged
merged 13 commits into from
Feb 19, 2021

Conversation

ousttrue
Copy link
Contributor

#450

唯一のロードメソッド

public virtual async Task ImporterContext.LoadAsync(Func<Task> nextFrame = null)

へと変更した。
その他のLoad呼び出しは、 ImporterContextExtensions.cs に追い出し。

Editor や UnityTest で同期的に実行したい場合は、

TemporarySynchronizationContext により一時的に SynchronizationContext を置き換えてUnityのmainloopからタスクを奪って自前で消化することができた。

1フレーム待ち nextFrame は Func<Task> で外から差し込むことにした。

@ousttrue ousttrue requested review from Santarh and hiroj February 16, 2021 11:51
Copy link
Contributor

@Santarh Santarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すごくよさそう

@ousttrue ousttrue merged commit c7a27fa into vrm-c:master Feb 19, 2021
@ousttrue ousttrue deleted the feature/remove_depthfirstscheduler branch April 2, 2021 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants