Use unijson parser #184
Merged
Use unijson parser #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ousttrue
force-pushed
the
use_unijson_parser
branch
from
038b3c0 to
839847e
Compare
|
Separate #189 |
yutopp
approved these changes
Feb 14, 2019
| { | ||
|
|
||
| } | ||
|
|
||
| public glTFBuffer(IBytesBuffer storage) |
There was a problem hiding this comment.
Suggested change
| public glTFBuffer(IBytesBuffer storage) | |
| public glTFBuffer(IBytesBuffer storage) : this() |
There was a problem hiding this comment.
I think that it is not necessary
There was a problem hiding this comment.
Oops, sorry. Other fields are not initialized by the default constructor. You are right.
| public glTFMesh() | ||
| { | ||
| } | ||
|
|
||
| public glTFMesh(string _name) |
There was a problem hiding this comment.
Suggested change
| public glTFMesh(string _name) | |
| public glTFMesh(string _name) : this() |
There was a problem hiding this comment.
I think that it is not necessary
|
Please wait merging this PR until |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add experimental switch ImporterContext.UseUniJSONParser .