Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter] shader版の StandardMap の Exporter 変換を追加 #1207

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

ousttrue
Copy link
Contributor

@ousttrue ousttrue commented Sep 9, 2021

#1178

  • 変数名が Exporter になっていたのを Importer に修正
  • 然る後に Exporter 一式追加

daitai

左エクスポート前、右エクスポート後再インポート。見分けは付かないのでたぶん OK

@ousttrue ousttrue added this to the v0.83 milestone Sep 9, 2021
@ousttrue ousttrue requested a review from Santarh September 9, 2021 09:52
Copy link
Contributor

@Santarh Santarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそう

private static Material exporter;
private static Material Exporter
private static Material _importer;
private static Material Importer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

命名ミスってた

half smoothness = metallicRoughnessTex.a * _UnitySmoothness; // A: Unity Roughness
half metallic = metallicRoughnessTex.r; // R: Unity Metallic

fixed4 result;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ちなみにここが fixed なのは 1/255 精度に丸めたい意図ですね、まあコンパイラや実行環境で容易に消されそうだけど

@ousttrue ousttrue merged commit 153fca3 into vrm-c:master Sep 9, 2021
@ousttrue ousttrue deleted the fix/add_StandardMapExporter branch October 27, 2021 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants